Skip to content

Dev container setup doesn't support node 18 base image #215432

@dangerman

Description

@dangerman

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.90.0
  • OS Version: Darwin arm64 23.5.0 (macOS Sonoma 14.5)

Steps to Reproduce:

  1. Follow the Quick start - local section of the DevContainer guide

  2. Then, in the Try it section the first step (after connecting to the container) is to run:

yarn install
bash scripts/code.sh

Expected

Yarn install should complete successfully, and code.sh should run the app.

Actual

We get the following error:
Please use latest Node.js v20 LTS for development

yarn-install-failure

Cause

According to the Dockerfile we're using typescript-node:18-bookworm.

20 is the current LTS, and 18 hasn't been in active support since October last year.

Proposed fix

We can use the node 20 version of the typescript dev container image: typescript-node:20-bookworm.

Note

For context: there was a compatibility issue with eslint-plugin-jsdoc@39.3.2 and node 20, as noted in the issue when we switched to the node 18 image:
#190331 (comment)

But it seems like this was resolved in 43.0.5:
gajus/eslint-plugin-jsdoc#1027 (comment)

And we're on on 46.5.0 now, so it should be fine ✅

Metadata

Metadata

Assignees

Labels

insiders-releasedPatch has been released in VS Code Insiders

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions