-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authordebtCode quality issuesCode quality issueshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderswebIssues related to running VSCode in the webIssues related to running VSCode in the web
Milestone
Description
In the LifecycleService you have a startupKind that on electron is used in stuff like the layoutService to determine whether to restore the sidebar contents only on a reload. But on web this is hardcoded to always restore the contents, not just on a reload.
It's possible to detect the navigation type in browsers by doing performance.navigation.type === 1 which would indicate a reload. So I suggest you should read the property, and expose it to under the startupKind property (removing all the hardcoding on the web) so all the features work as expected
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authordebtCode quality issuesCode quality issueshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderswebIssues related to running VSCode in the webIssues related to running VSCode in the web