-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderslayoutGeneral VS Code workbench layout issuesGeneral VS Code workbench layout issuesverifiedVerification succeededVerification succeeded
Milestone
Description
On this line
vscode/src/vs/workbench/browser/layout.ts
Line 2614 in 57ea32b
| LayoutStateKeys.PANEL_SIZE.defaultValue = (this.stateCache.get(LayoutStateKeys.PANEL_POSITION.name) ?? LayoutStateKeys.PANEL_POSITION.defaultValue) === 'bottom' ? workbenchDimensions.height / 3 : workbenchDimensions.width / 4; |
it checks to bottom string, but because the value in the stateCache is unknown typescript doesn't consider it an error.
The actual type is a Position enum, which is a number so the check === 'bottom' should be changed otherwise it's defaulting to the width sizing (when it should be height) which is wrong
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderslayoutGeneral VS Code workbench layout issuesGeneral VS Code workbench layout issuesverifiedVerification succeededVerification succeeded