Skip to content

Default panel sizing is wrong #206296

@samdenty

Description

@samdenty

On this line

LayoutStateKeys.PANEL_SIZE.defaultValue = (this.stateCache.get(LayoutStateKeys.PANEL_POSITION.name) ?? LayoutStateKeys.PANEL_POSITION.defaultValue) === 'bottom' ? workbenchDimensions.height / 3 : workbenchDimensions.width / 4;

it checks to bottom string, but because the value in the stateCache is unknown typescript doesn't consider it an error.

The actual type is a Position enum, which is a number so the check === 'bottom' should be changed otherwise it's defaulting to the width sizing (when it should be height) which is wrong

Metadata

Metadata

Assignees

Labels

author-verification-requestedIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsiderslayoutGeneral VS Code workbench layout issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions