Skip to content

Insiders is no longer removing obsolete (superseded) extension folders #189334

New issue
New issue
Closed
#189335
Closed
Insiders is no longer removing obsolete (superseded) extension folders#189334
#189335
Assignees
alexdimasandy081
Labels
bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseinsiders-releasedPatch has been released in VS Code InsidersregressionSomething that used to work is now brokenverifiedVerification succeeded
Milestone
July 2023
@gjsjohnmurray

Description

@gjsjohnmurray
gjsjohnmurray
opened on Jul 31, 2023

I think this got broken very recently by 12e03ad (PR #188917 by @sandy081)

The arguments passed to isEqualOrParent here are reversed.

vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts

Lines 573 to 575 in e1b9eed

if (this.uriIdentityService.extUri.isEqualOrParent(this.extensionsScannerService.userExtensionsLocation, extension.location)) {
return this.deleteExtensionFromLocation(extension.identifier.id, extension.location, type);
}

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugcandidateIssue identified as probable candidate for fixing in the next releaseinsiders-releasedPatch has been released in VS Code InsidersregressionSomething that used to work is now brokenverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions