-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
debugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderspolishCleanup and polish issueCleanup and polish issue
Milestone
Description
We ran into this at Google:
Currently, VSCode will use F10 (like many debuggers) for stepping over on Electron, but Alt+F10 on Web. The rationale, according to the code comment, is that browsers will not allow you to bind F10:
| primary: isWeb ? (KeyMod.Alt | KeyCode.F10) : KeyCode.F10, // Browsers do not allow F10 to be binded so we have to bind an alternative |
I believe that is not fully correct:
- VSCode itself uses F10 (curiously exactly when in the browser), to focus the file menu:
primary: KeyCode.F10, - I changed the shortcut to F10 in the settings, and in my browser (Chrome on OS X) it worked fine - maybe it does not work on specific browsers?
@isidorn, you removed F10 for step over on web in f0cf34e - do you recall the exact reason?
@sbatten, you added the F10 for application menu on web - why is this only on web?
I would like to better understand if we can somehow make this work, as users generally expect F10 to step over in debuggers, and having to type Alt+F10 for step over, when e.g. step in is just F11 is causing friction.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
debugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderspolishCleanup and polish issueCleanup and polish issue