Skip to content

ITerminalService#getActiveOrCreateInstance returns a disposed terminal #180018

Closed
#180451
Closed
ITerminalService#getActiveOrCreateInstance returns a disposed terminal#180018
#180451
Assignees
Tyriarmeganrogge
Labels
author-verification-requestedIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-editorsverifiedVerification succeeded
Milestone
May 2023
@roblourens

Description

@roblourens
roblourens
opened on Apr 14, 2023
  • Open a Terminal Editor
  • Close it
  • Call ITerminalService#getActiveOrCreateInstance
  • Get a terminal that has isDisposed = true
  • Try to reveal the terminal, and it isn't shown

Noticed this with https://github.com/microsoft/vscode/pull/180017/files#diff-0cce141a5c2c60f7c15454df04f32133a8364c97b5d67af79de9d2f4bfb0aebbR212-R215, I can work around this but it seems wrong?

Metadata

Metadata

Assignees

Labels

author-verification-requestedIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersterminal-editorsverifiedVerification succeeded

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions