Due to an oversight, TestInstantiationService.createInstance() does not enforce arguments or its return type. Fixing this exposes around 80 typings errors in our codebase that should be addressed

To fix this issue in your code:

1. In instantionService, comment out the first signature for createInstance. (Do not check in this change. I will check in the change to the signature once all error have been fixed)

2. Now look at the file assigned to you and fix the type error (you may need to restart the compile since we are changing such a core type)

Affected files

• — src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts @meganrogge @Tyriar
• — src/vs/workbench/contrib/terminal/test/browser/links/terminalUriLinkDetector.test.ts @meganrogge @Tyriar
• — src/vs/workbench/contrib/terminal/test/browser/links/terminalLocalLinkDetector.test.ts @meganrogge @Tyriar
• — src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkManager.test.ts @meganrogge @Tyriar
• — src/vs/workbench/contrib/notebook/test/browser/contrib/notebookOutline.test.ts @rebornix
• — src/vs/workbench/services/dialogs/test/electron-sandbox/fileDialogService.test.ts @alexr00
• — src/vs/workbench/contrib/terminal/test/common/history.test.ts @meganrogge
• — src/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts @meganrogge
• — src/vs/workbench/contrib/search/test/common/searchResult.test.ts @andreamah
• — src/vs/workbench/contrib/search/test/browser/searchViewlet.test.ts @andreamah
• — src/vs/workbench/contrib/search/test/browser/searchActions.test.ts @andreamah
• — src/vs/workbench/contrib/notebook/test/browser/notebookKernelService.test.ts @mjbvz
• — src/vs/workbench/contrib/notebook/test/browser/notebookExecutionService.test.ts @roblourens
• — src/vs/workbench/contrib/notebook/test/browser/notebookEditorModel.test.ts @mjbvz
• — src/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts @sandy081
• — src/vs/workbench/contrib/extensions/test/electron-browser/extensionsActions.test.ts @sandy081
• — src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts @hediet
• — src/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts @jrieken
• — src/vs/platform/terminal/test/common/requestStore.test.ts @Tyriar