-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-shell-zshAn issue in the terminal specific to zsh, including shell integrationAn issue in the terminal specific to zsh, including shell integrationverifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes/No
- VS Code Version: 1.72.2
- OS Version: macOS Monterey 12.5
Steps to Reproduce:
- Configure custom HISTFILE (example custom HISTFILE per project)
- Load integrated terminal (zsh) in VS code
- HISTFILE will be /Users/
<user>/.zsh_history instead of custom history file
What i use:
vscode settings.json:
"terminal.integrated.env.osx": {
"WORKSPACE_HISTFILE": "true",
"SHELL": "/bin/zsh",
},
~/.zshrc
if [[ "${WORKSPACE_HISTFILE:-false}" == "true" ]]; then
history_file="${HOME}/.zsh_history_files/.zsh_history_${PWD//\//_}"
echo ">>> Loading Workspace History File [$history_file]"
export HISTFILE=$history_file
fc -W
fi
I found that the changes made to break the ability to use a custom HISTFILE because the HISTFILE is always overwritten by these changes:
https://github.com/microsoft/vscode/pull/154300/files#diff-b5f144ca334c56807b1af2c57851271f3c7af88fed7a4287a2627c46ebb97d05R25-R27
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bughelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersterminal-shell-zshAn issue in the terminal specific to zsh, including shell integrationAn issue in the terminal specific to zsh, including shell integrationverifiedVerification succeededVerification succeeded