Skip to content

Add separate theme color(s) for comments in overview ruler / scrollbar #156653

@hermannloose

Description

@hermannloose

Decorations for lines with review comments are currently drawn in the center lane of the overview ruler / scrollbar using the same color as the editor gutter decorations for commenting ranges, editorGutter.commentRangeForeground (source). The bright gray used for the editor gutter decorations is not very distinct from the color used for search results or occurrences of the current token under the cursor, which are drawn in the same lane.

We would like the flexibility of a new theme color (which can by default inherit from editorGutter.commentRangeForeground) to allow users to have the comments be more noticeable, while not affecting the editor gutter decorations.

As #127473 is being finalized, it might also make sense to go for two new theme colors right away, one for unresolved comment threads (which users likely want more prominent) and one for resolved comment threads (which can probably be more subtle), e.g. editorOverviewRuler.unresolvedComment and editorOverviewRuler.resolvedComment.

Alternatively, if new colors should be kept to a minimum, we could also work with the overview ruler reusing editorCommentsWidget.unresolvedBorder and editorCommentsWidget.resolvedBorder, although that starts to erode the scope that those color names suggest.

cc @alexr00 @laurentlb @albertelo

Metadata

Metadata

Assignees

Labels

commentsComments Provider/Widget/Panel issuesfeature-requestRequest for new features or functionalityverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions