Skip to content

Polish shell integration messaging #148839

@Tyriar

Description

@Tyriar

Action items after a discussion:

  • Explain when shell integration may fail to activate in the setting docs, ie. complex prompt command for example (debug trap specified?)
  • Remove in-terminal shell integration disabled warning
  • Hide shell integration activated message in favor of an item in the command decoration? How does this work? Learn more?
    • The reason we had the activated message to begin with was to disclose to people that we have performed some script injection. We believe it's sufficient now just showing the rich command decorations (and the terminal tab hover) as an indicator, also with documentation on the website that explains how the terminal works.
  • Remove capabilities from tab hover, only say "Shell integration activated" or "Shell integration failed to activate"

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bugfeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insiderson-release-notesIssue/pull request mentioned in release notesterminal-shell-integrationShell integration infrastructure, command decorations, etc.verification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions