-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buggithubGithub extensionGithub extensioninsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes/No
Version: 1.66.2 (Universal)
Commit: dfd34e8
Date: 2022-04-11T07:49:20.994Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Darwin x64 20.5.0
Steps to Reproduce:
- Just push a commit to a repo that user don't have permission
- A message modal will show to ask user if they want to create a fork repo
- Click
closebutton - VSCode create a fork for you
- But user don't want to creat a fork, that's why they close it.
I check the code, looks like github extention only check no to return.
What I suggest
if (answer !== yes) {
return;
}If you think this were resonable, I will make a PR for it
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buggithubGithub extensionGithub extensioninsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
