Skip to content

Close create fork message will create a fork #148437

@susiwen8

Description

@susiwen8

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.66.2 (Universal)
Commit: dfd34e8
Date: 2022-04-11T07:49:20.994Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Darwin x64 20.5.0

Steps to Reproduce:

  1. Just push a commit to a repo that user don't have permission
  2. A message modal will show to ask user if they want to create a fork repo
  3. Click close button
  4. VSCode create a fork for you
  5. But user don't want to creat a fork, that's why they close it.

Screen Shot 2022-04-29 at 11 18 18 PM

I check the code, looks like github extention only check no to return.

What I suggest

	if (answer !== yes) {
		return;
	}

If you think this were resonable, I will make a PR for it

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buggithubGithub extensioninsiders-releasedPatch has been released in VS Code InsidersverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions