-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Closed
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersmarkdownMarkdown support issuesMarkdown support issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
A script for Markdown preview from my extension accidentally met collision with a minimized global variable provided by VS Code. It brought a broken Markdown preview that is difficult to debug a problem.
marp-team/marp-vscode#345 (comment)
I think extension authors might want to take care with global namespace pollution, but applying IIFE into VS Code's Markdown preview script also would be better to save extensions from accidental breaking.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersmarkdownMarkdown support issuesMarkdown support issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded