-
Notifications
You must be signed in to change notification settings - Fork 37.4k
Closed
Labels
Milestone
Description
Refs: #134790
Complexity: 3
Authors: @meganrogge
We want to align the terminal find experience with that of the editor, so this iteration, made use of the new Xterm registerDecoration API to do so.
Verify that the find experience in the terminal:
- feels nice
- looks good
- behaves similarly to the editor
- shows scrollbar annotations in the right places and an indicator for the currently selected term that updates with
findNextandfindPrevious - try setting
workbench.colorCustomizations.editor.findMatchBackgroundandworkbench.colorCustomizations.editor.findMatchHighlightBackgroundto custom colors. These should work on the next search - try searching for something then adding lines to the buffer - the search results should be updated
- scrolling shouldn't impact anything
- closing the find widget (that still has input) should remove the decorations
- clearing the find widget should delete the decorations
Known issues: