Skip to content

Improve command tracking scroll behavior #145241

@Tyriar

Description

@Tyriar

Current when scrolling to commands in the terminal (cmd+up/down) it will scroll the command to the top of the terminal. We should instead align with breakpoints/outline/go to symbol and improve this considering we're getting a highlight in #46561 which will make the line in question more obvious.

The exact behavior I'll do is:

  • When the command is in the viewport: Don't scroll, just highlight
  • When the command is not in the viewport: Scroll to it and position the command in the first 1/3 or 1/4 of the viewport*

* This aligns with how Go to Symbol does it, breakpoints/outline by contrast goes to the center. I'd argue that for commands, similar to navigating to a symbol, the lower context is much more important and since that gives precedence we should align with that behavior.

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insiderson-testplanterminal-shell-integrationShell integration infrastructure, command decorations, etc.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions