-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Description
We've had the command tracking feature for ~4 years now but it's rarely used/discovered as keybindings only exist on macOS. Since we have highlights coming which make the feature more intuitive as well as much more reliable command detection thanks to shell integration, I'm proposing we add the following default keybindings on Linux and Windows to help users discover the feature.
{ "key": "ctrl+up", "command": "workbench.action.terminal.scrollToPreviousCommand", "when": "terminalFocus" },
{ "key": "ctrl+down", "command": "workbench.action.terminal.scrollToNextCommand", "when": "terminalFocus" },
{ "key": "ctrl+shift+up", "command": "workbench.action.terminal.selectToPreviousCommand", "when": "terminalFocus" },
{ "key": "ctrl+shift+down", "command": "workbench.action.terminal.selectToNextCommand", "when": "terminalFocus" },The reason these weren't added initially was a concern they would conflict with shell keybindings. I think at this point adding them outweighs that downside considering we now have the terminal.integrated.sendKeybindingsToShell setting which when set to true will ignore them as well as other mechanisms to disable the defaults (unbinding the keybindings, remove the commands from terminal.integrated.commandsToSkipShell.