Skip to content

keytar brings in a lot of files in the build #143395

@aeschli

Description

@aeschli

I'm looking into reducing the number of files in our server build.

Turns out that keytar brings in a lot of file because the use of prebuild-install in the install script.
Because of that prebuild-install is a dependency (not just a dev dependency) and prebuild-install and all it's dependencies end up in the bits we ship (tar-fs, tar-stream, readable-stream....).

It's not easy to remove all these unnecessary from the build. We have a hand curated filter (https://github.com/microsoft/vscode/blob/main/build/.moduleignore) but that's cumbersome and might change after an update.

Metadata

Metadata

Labels

authenticationIssues with the Authentication platformdebtCode quality issuesinsiders-releasedPatch has been released in VS Code Insiders

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions