-
Notifications
You must be signed in to change notification settings - Fork 38.3k
Closed
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeededwebIssues related to running VSCode in the webIssues related to running VSCode in the web
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes/No
- VS Code Version: 1.63.0 (the code seems to be the same at main)
- OS Version: Mac 12.2.1 / web
Steps to Reproduce:
- Open vscode in a browser tab
- Switch to the PWA
- Open a new window
- Observe that the new window opens in a new browser tab, rather than a new standalone window
This is because whether it opens in a new standalone window is determined by the constant isStandalone.
However, this property isn't constant, resulting in unexpected behaviour if it changes.
It would be better to instead make this a method. We can avoid having to poll each time by adding a watcher to this method.
I'll follow up with a PR.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
author-verification-requestedIssues potentially verifiable by issue authorIssues potentially verifiable by issue authorbugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeededwebIssues related to running VSCode in the webIssues related to running VSCode in the web