Skip to content

gulp-eslint uses eslint 5.16.0 and not 8.7.0 #142183

@alexdima

Description

@alexdima
  • in the root package.json we use eslint 8.7.0
  • the editor integration of eslint will pick up that one
  • however, in our build scripts we depend on gulp-eslint which brings its own version of eslint.

This mismatch can manifest itself as differences between the editor squiggles and the build machine which can lead to breaking the build. e.g.

  • go to src/vs/editor/contrib/links/browser/links.ts
  • add import * as async from 'vs/base/common/async';
  • and use it somewhere console.log(async);

The editor does not report a warning, while yarn eslint reports a warning.

cc @dbaeumer

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bugengineeringVS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code InsidersverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions