-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded
Milestone
Description
- in the root
package.jsonwe useeslint8.7.0 - the editor integration of eslint will pick up that one
- however, in our build scripts we depend on
gulp-eslintwhich brings its own version ofeslint.
This mismatch can manifest itself as differences between the editor squiggles and the build machine which can lead to breaking the build. e.g.
- go to
src/vs/editor/contrib/links/browser/links.ts - add
import * as async from 'vs/base/common/async'; - and use it somewhere
console.log(async);
The editor does not report a warning, while yarn eslint reports a warning.
cc @dbaeumer
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.insiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersverifiedVerification succeededVerification succeeded