TypeScript plugin extensions don't load on Windows in 1.64.0 #142139
Description
- VS Code Version: 1.64.0
- OS Version: Windows 10
Steps to Reproduce:
- Load an extension that uses a TypeScript server plugin like:
With tsserver logs enabled, you will notice the following in the logs:
Info 0 [18:48:17.280] Starting TS Server
Info 1 [18:48:17.281] Version: 4.5.5
Info 2 [18:48:17.281] Arguments: C:\Users\david\AppData\Local\Programs\Microsoft VS Code\Code.exe c:\Users\david\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName C:\Users\david\AppData\Local\Temp\vscode-typescript\43a6ae4ad4818b5f148f\tscancellation-46d2cad07af3976cd9e1.tmp* --logVerbosity verbose --logFile c:\Users\david\AppData\Roaming\Code\logs\20220203T181651\exthost7\vscode.typescript-language-features\tsserver-log-Hl2L4q\tsserver.log --globalPlugins typescript-deno-plugin --pluginProbeLocations /c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation
Info 3 [18:48:17.281] Platform: win32 NodeVersion: 14 CaseSensitive: false
...
Info 18 [18:48:17.298] Loading global plugin typescript-deno-plugin
Info 19 [18:48:17.298] Enabling plugin typescript-deno-plugin from candidate paths: /c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1,c:/Users/david/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../..
Info 20 [18:48:17.298] Loading typescript-deno-plugin from /c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1 (resolved to C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules)
Info 21 [18:48:17.309] Loading typescript-deno-plugin from c:/Users/david/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/typescript/lib/tsserver.js/../../.. (resolved to c:/Users/david/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/node_modules/node_modules)
Info 22 [18:48:17.310] Failed to load module 'typescript-deno-plugin' from C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules: Error: Could not resolve JS module 'typescript-deno-plugin' starting at 'C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules'. Looked in: C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules/typescript-deno-plugin/package.json, C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules/typescript-deno-plugin.js, C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules/typescript-deno-plugin.jsx, C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules/typescript-deno-plugin/index.js, C:/c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1/node_modules/typescript-deno-plugin/index.jsx,
...etc...
Cause?
This may be because vscode started to provide a pluginProbeLocations to tsserver in the following format:
--pluginProbeLocations /c:/Users/david/.vscode/extensions/denoland.vscode-deno-3.10.1
Previously in 1.63 it used this format:
--pluginProbeLocations c:\Users\david\.vscode\extensions\denoland.vscode-deno-3.10.1
So it's now resolving /c:/ to C:/c:/ within ts server.
I will keep investigating.