-
Notifications
You must be signed in to change notification settings - Fork 38.4k
Description
Issue Type: Bug
Debug adapters have long been able to provide uris along with error responses, and these uris add buttons to the error dialog. Now that my PR #123833 has merged these can be command uris.
However it is not currently possible to prevent an extra 'Open launch.json' button being added to the error dialog.
In some situations there may be no point in the user opening launch.json. Instead they should use a button that the error response added.
@isidorn would it be reasonable for us to suppress addition of the 'Open launch.json' button when the error is adding its own command-type button(s)? Limiting the change in this way should minimize the chance of upsetting existing DAs which return uris with their errors. It's unlikely they have been returning command-type uris because until now these haven't been actionable.
VS Code version: Code - Insiders 1.57.0-insider (40d5e67, 2021-05-14T20:13:58.234Z)
OS version: Windows_NT x64 10.0.19042