-
Notifications
You must be signed in to change notification settings - Fork 38.3k
Closed
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderssandboxRunning VSCode in a node-free environmentRunning VSCode in a node-free environmentsearchSearch widget and operation issuesSearch widget and operation issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
We need to remove node dependencies of the renderer for our sandbox effort. Search is currently a process that is triggered from the renderer (via vs/workbench/services/search/electron-browser/searchService et al). Going forward, we should move this into one of the processes that is allowed to execute node:
- shared process
- extension host
Filing this to get a discussion starting how to tackle this. With terminals moved, @Tyriar and @meganrogge have demonstrated that the shared process is a viable host for native processes and the patterns used for terminals can be applied to this one as well.
#116337 has a diagram for how the shared process today is being used as host for privileged processes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsiderssandboxRunning VSCode in a node-free environmentRunning VSCode in a node-free environmentsearchSearch widget and operation issuesSearch widget and operation issuesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded