Skip to content

Move search app out of renderer into shared process or extension host #118200

@bpasero

Description

@bpasero

We need to remove node dependencies of the renderer for our sandbox effort. Search is currently a process that is triggered from the renderer (via vs/workbench/services/search/electron-browser/searchService et al). Going forward, we should move this into one of the processes that is allowed to execute node:

  • shared process
  • extension host

Filing this to get a discussion starting how to tackle this. With terminals moved, @Tyriar and @meganrogge have demonstrated that the shared process is a viable host for native processes and the patterns used for terminals can be applied to this one as well.

#116337 has a diagram for how the shared process today is being used as host for privileged processes.

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsiderssandboxRunning VSCode in a node-free environmentsearchSearch widget and operation issuesverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions