Improve user troubleshooting message#957
Merged
BillyONeal merged 6 commits intomicrosoft:mainfrom Mar 20, 2023
Merged
Conversation
Incomplete issues are still created. The generated issue body gets now more promotion.
BillyONeal
reviewed
Mar 16, 2023
| { | ||
| auto path = issue_body.get()->generic_u8string(); | ||
| result.append_indent().append_fmt_raw("https://github.com/microsoft/vcpkg/issues/" | ||
| "new?title=[{}]+Build+error&body=Copy+issue+body+from+{}\n", |
Member
There was a problem hiding this comment.
In this URI why are the spaces in the title turned into +s but not spaces in the Strings::percent_encode(path) ?
Contributor
Author
There was a problem hiding this comment.
Because percent encoding does not allow to decode spaces as +, in general the URI RFC does not know the + encoding for spaces, but in the HTML spec they say the body of a form is application/x-www-form-urlencoded and can be submitted via "get".
Because + is shorter than %20 I used it here for the spaces.
Co-authored-by: Billy O'Neal <bion@microsoft.com>
BillyONeal
approved these changes
Mar 20, 2023
# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/base/messages.cpp
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete issues are still often created. The generated issue body now gets more promotion.
Before:
After: