Fix wrong "Total elapsed time" messages#170
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Oct 1, 2021
Merged
Conversation
Member
|
I'm not sure I agree with this fix because it extends use of globals and leaves the potentially misleading |
Contributor
Author
|
I think we can completely remove the |
BillyONeal
approved these changes
Sep 30, 2021
Member
Sounds good, can you do that? :) |
c4bb2d5 to
58664ea
Compare
58664ea to
faef08c
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#16850
Maybe somewhere internally a function need the current printed time, but as an end user I am only interested in the real "total elapsed time" and not how long some internally sub function needs.