Set compiler file hash cache variable#1558
Merged
BillyONeal merged 5 commits intoJan 16, 2025
Merged
Conversation
BillyONeal
approved these changes
Jan 3, 2025
autoantwort
commented
Jan 3, 2025
| inline constexpr StringLiteral FileBaselineDotJson = "baseline.json"; | ||
| inline constexpr StringLiteral FileBin = "bin"; | ||
| inline constexpr StringLiteral FileControl = "CONTROL"; | ||
| inline constexpr StringLiteral FileCompilerFileHashCacheDotJson = "compiler-file-hash-cache.json"; |
Contributor
Author
There was a problem hiding this comment.
I didn't put it here initially because you could put the file anywhere and wouldn't break anyone. I don't know what the exact rule is (when to put stuff in this header and when not).
Member
There was a problem hiding this comment.
I think the idea is that any 'magic names' should go in here. This thing mostly exists to prevent typoing the name should we need to reference it somewhere else again, at least that's my understanding based on @ras0219-msft 's feedback that created this header in the first place.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Needed" for microsoft/vcpkg#42994