Skip to content

[icu] update to 59.1#965

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
codicodi:icu59
Apr 25, 2017
Merged

[icu] update to 59.1#965
ras0219-msft merged 2 commits intomicrosoft:masterfrom
codicodi:icu59

Conversation

@codicodi
Copy link
Copy Markdown
Contributor

This also switches icu to autotools based buildsystem, enabling all flavors of desktop builds.

@ras0219-msft ras0219-msft merged commit 62f9b23 into microsoft:master Apr 25, 2017
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for the update!

The issue with the path was most likely due to find resolving to C:\windows\system32\find.exe instead of GNU find. Instead of modifying the MSYS2 enlistment (and possibly leaving it in a bad state if the build fails!) I changed the portfile to insert the path in the middle.

Could you comment on why you chose to do several individual calls to bash instead of using a separate script (like in ffmpeg)?

@codicodi codicodi deleted the icu59 branch April 25, 2017 15:07
@codicodi
Copy link
Copy Markdown
Contributor Author

Nothing special, just thought the logs will be a little cleaner this way.

@PhoebeHui PhoebeHui mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants