Skip to content

[moltenvk] add new port#9575

Closed
magicfoo wants to merge 1 commit intomicrosoft:masterfrom
magicfoo:port_moltenvk
Closed

[moltenvk] add new port#9575
magicfoo wants to merge 1 commit intomicrosoft:masterfrom
magicfoo:port_moltenvk

Conversation

@magicfoo
Copy link
Copy Markdown

@magicfoo magicfoo commented Jan 7, 2020

Add new port for moltenVK library.
This port only supports macOS platform to provide a compliant API to Vulkan based on native Metal.

@magicfoo magicfoo mentioned this pull request Jan 7, 2020
Closed
@JackBoosY JackBoosY requested a review from NancyLi1013 January 8, 2020 03:04
NancyLi1013
NancyLi1013 suggested changes Jan 8, 2020
View reviewed changes
ports/moltenvk/portfile.cmake Outdated
Copy link
Copy Markdown
Contributor

@NancyLi1013 NancyLi1013 Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commit id from v1.0.38? I noticed that v1.0.39 has been released. Why do you not use the latest version?

Copy link
Copy Markdown
Author

@magicfoo magicfoo Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it is more risky to automatically use the latest version as the port file could be obsolete quickly due. Better, IMHO again, to be in favor of more stability in vcpkg with manual update of packages and related port files ... As a user, I don't like things that break frequently for no good reason. Most of the time, users don't need latest version/ features, except for bug fixes requiring a manual update. TBD

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 8, 2020

Hi @magicfoo thanks for this PR.
Since this port only supports macOS platform. Please update baseline with the following content:

moltenvk:x86-windows=fail
moltenvk:x64-windows=fail
moltenvk:x64-windows-static=fail
moltenvk:x64-uwp=fail
moltenvk:arm-uwp=fail
moltenvk:arm64-windows=fail
moltenvk:x64-linux=fail

@magicfoo magicfoo force-pushed the port_moltenvk branch 2 times, most recently from 9b74eb5 to 08b26ee Compare January 8, 2020 23:52
magicfoo
magicfoo commented Jan 9, 2020
View reviewed changes
ports/moltenvk/portfile.cmake Outdated
Comment on lines 19 to 21
Copy link
Copy Markdown
Author

@magicfoo magicfoo Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this port is intentionally locked to a stable version known to build properly.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 9, 2020

/azp run

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 10, 2020

I noticed that this port failed on OSX pipeline.
I get this info from CI system in fetch-dependencies-x64-osx-rel-err.log

HEAD is now at 204cd13 Merge pull request #134 from Tobski/patch-1
fetchDependencies: line 109: cmake: command not found

Could you please check this?

@magicfoo
Copy link
Copy Markdown
Author

magicfoo commented Jan 10, 2020 •
edited
Loading

I noticed that this port failed on OSX pipeline.
I get this info from CI system in fetch-dependencies-x64-osx-rel-err.log

HEAD is now at 204cd13 Merge pull request #134 from Tobski/patch-1
fetchDependencies: line 109: cmake: command not found

Could you please check this?

Do you have more details please? It doesn't fail on my laptop. MoltenVK needs xcode 11.3 (catalina). Note that from my tests, few ports including glib will start failing with the new xcode 11.3. My other PR (#9593) fixes this issue on macos.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 14, 2020

Thanks for your feedback.
I will rerun and let's wait for the new test result from CI system.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 14, 2020

/azp run

1 similar comment
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Jan 21, 2020

/azp run

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 3, 2020

It seems that it still failed on osx pipeline.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Feb 20, 2020

Hi @magicfoo
Could you please resolve the conflicts?

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Mar 5, 2020

Pinging @magicfoo
Is work still being done for this PR?

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Apr 16, 2020

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@Haeri Haeri mentioned this pull request Nov 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@magicfoo @NancyLi1013