Skip to content

[soem] Add new port#9572

Merged
vicroms merged 5 commits intomicrosoft:masterfrom
seanyen:SOEM
Jan 14, 2020
Merged

[soem] Add new port#9572
vicroms merged 5 commits intomicrosoft:masterfrom
seanyen:SOEM

Conversation

@seanyen
Copy link
Copy Markdown
Member

@seanyen seanyen commented Jan 7, 2020

@seanyen
Copy link
Copy Markdown
Member Author

seanyen commented Jan 7, 2020

@NancyLi1013 Thanks for the feedback. I have made the respective changes.

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@NancyLi1013
Copy link
Copy Markdown
Contributor

Hi @seanyen thanks for this PR.
I noticed that this port failed on x64-uwp and arm-uwp triplets from CI system.
Are these expected? If not, please try to fix them.

If this port doesn't support arm, please add vcpkg_fail_port_install(ON_TARGET "UWP") to the top of portfile.cmake.
Also update baseline with the following content:

soem:x64-uwp=fail
soem:arm-uwp=fail

@PhoebeHui PhoebeHui changed the title [soem] add v1.4.0 port [soem] Add new port Jan 10, 2020
@PhoebeHui PhoebeHui self-assigned this Jan 10, 2020
@seanyen
Copy link
Copy Markdown
Member Author

seanyen commented Jan 13, 2020

@NancyLi1013 @PhoebeHui Thanks for the feedback. I have revised this PR respectively.

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 14, 2020
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jan 14, 2020

Thanks for the PR!

@vicroms vicroms merged commit fc5134c into microsoft:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants