[qt5-base] missing files in export/CI caching#5608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts #5456 in order to fix #5566 while trying not to regress #5455. There are also a few outstanding PRs that have failures in ports with dependences on qt5-base because the way the CI system avoids building unchanged ports by caching the build results.
I have tested this change to verify that it fixes the issues so I am going to push to get it merged so other changes can be unblocked. However there is more work that will need to be done in the future to avoid directly using CURRENT_INSTALLED_DIR in the build. It also shows a need to better test exporting in the CI system to avoid regressions like this in the future.