Skip to content

[hical61-hical] Update to version 2.6.1#51671

Merged
vicroms merged 3 commits into
microsoft:masterfrom
Hical61:hical61-hical-v2.6.0
May 14, 2026
Merged

[hical61-hical] Update to version 2.6.1#51671
vicroms merged 3 commits into
microsoft:masterfrom
Hical61:hical61-hical-v2.6.0

Conversation

@Hical61

@Hical61 Hical61 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Changes

Update hical61-hical to version 2.6.1.

Upstream release: https://github.com/Hical61/Hical/releases/tag/v2.6.1

Port changes

  • Updated version to 2.6.1 in vcpkg.json
  • Updated SHA512 in portfile.cmake
  • Removed boost-beast dependency (replaced by native HTTP/WebSocket stack)
  • Added picohttpparser dependency (port merged in [picohttpparser] Add new port, devendor from [cinatra] #51743)
  • Added zlib dependency (required for WebSocket permessage-deflate)
  • Added -DHICAL_USE_SYSTEM_PICOHTTPPARSER=ON build option
  • Updated description to reflect native stack

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@Hical61 Hical61 marked this pull request as ready for review May 12, 2026 02:50
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 12, 2026
@vicroms

vicroms commented May 12, 2026

Copy link
Copy Markdown
Member

Marking as requires:vcpkg-team-review because upstream now vendors src/third_party/picohttpparser.

@Hical61

Could you attempt creating a port for this library and providing an option to use the dependency from vcpkg instead of bundled code? That would resolve our concerns.

@vicroms vicroms marked this pull request as draft May 12, 2026 22:03
@Hical61

Hical61 commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Marking as requires:vcpkg-team-review because upstream now vendors src/third_party/picohttpparser.

@Hical61

Could you attempt creating a port for this library and providing an option to use the dependency from vcpkg instead of bundled code? That would resolve our concerns.

Hi @vicroms, thanks for the review!

I've addressed this in v2.6.1. The changes:

1、Added HICAL_USE_SYSTEM_PICOHTTPPARSER CMake option (default OFF). When ON, Hical uses find_path() + find_library() to locate a system-installed picohttpparser instead of compiling the bundled copy.

2、Created a picohttpparser overlay port (ports/picohttpparser/) that builds h2o/picohttpparser as a static library with proper CMake targets — since upstream doesn't provide a CMakeLists.txt or an official vcpkg port.

3、Updated the hical port to declare picohttpparser as a dependency and pass -DHICAL_USE_SYSTEM_PICOHTTPPARSER=ON during vcpkg builds.

This way, vcpkg users always consume picohttpparser through the port system, while non-vcpkg users (direct clone, MSYS2, etc.) continue to use the bundled version with zero extra configuration.

I'll update the SHA512 and push v2.6.1 shortly.

Follow-up on the picohttpparser port:

I have a working overlay port ready (with CMakeLists.txt, since upstream doesn't provide one). However, I'm hesitant to submit it to vcpkg on behalf of the upstream maintainer (h2o/picohttpparser).

Would the vcpkg team be willing to create the picohttpparser port? It's very small — just 2 files (~800 lines), MIT licensed. I can provide my overlay port as a starting point.

Alternatively, if you'd prefer I include it directly in this PR, I'm happy to do so. Just let me know which approach you prefer.

@Hical61

Hical61 commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Follow-up regarding the picohttpparser port:

I have a working overlay port ready (CMakeLists.txt + portfile.cmake), since upstream h2o/picohttpparser doesn't provide a CMakeLists.txt.

However, I'm hesitant to submit a port for this library to vcpkg on behalf of the upstream maintainer.

Would the vcpkg team be open to creating the picohttpparser port? It's very small — just 2 files (~800 lines), MIT licensed. I'm happy to provide my overlay port as a starting point.

If you'd prefer I include it directly in this PR instead, that works too — just let me know.

@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label May 13, 2026
@vicroms

vicroms commented May 13, 2026

Copy link
Copy Markdown
Member

@Hical61 I've created a port for picohttpparser in #51743

Hical61 added 2 commits May 14, 2026 11:12
- Update SHA512 for v2.6.1 release
- Add picohttpparser dependency (port merged in microsoft#51743)
- Pass -DHICAL_USE_SYSTEM_PICOHTTPPARSER=ON
- Remove boost-beast dependency (replaced by native HTTP/WebSocket stack)
@Hical61 Hical61 force-pushed the hical61-hical-v2.6.0 branch from f86181d to db353b6 Compare May 14, 2026 03:20
@Hical61 Hical61 changed the title [hical61-hical] Update to version 2.6.0 [hical61-hical] Update to version 2.6.1 May 14, 2026
@Hical61 Hical61 marked this pull request as ready for review May 14, 2026 03:37
@vicroms vicroms merged commit d0c191d into microsoft:master May 14, 2026
16 checks passed
@toge toge mentioned this pull request May 15, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants