[hical61-hical] Update to version 2.6.1#51671
Conversation
|
Marking as Could you attempt creating a port for this library and providing an option to use the dependency from vcpkg instead of bundled code? That would resolve our concerns. |
Hi @vicroms, thanks for the review! I've addressed this in v2.6.1. The changes: 1、Added HICAL_USE_SYSTEM_PICOHTTPPARSER CMake option (default OFF). When ON, Hical uses find_path() + find_library() to locate a system-installed picohttpparser instead of compiling the bundled copy. 2、Created a picohttpparser overlay port (ports/picohttpparser/) that builds h2o/picohttpparser as a static library with proper CMake targets — since upstream doesn't provide a CMakeLists.txt or an official vcpkg port. 3、Updated the hical port to declare picohttpparser as a dependency and pass -DHICAL_USE_SYSTEM_PICOHTTPPARSER=ON during vcpkg builds. This way, vcpkg users always consume picohttpparser through the port system, while non-vcpkg users (direct clone, MSYS2, etc.) continue to use the bundled version with zero extra configuration. I'll update the SHA512 and push v2.6.1 shortly. Follow-up on the picohttpparser port: I have a working overlay port ready (with CMakeLists.txt, since upstream doesn't provide one). However, I'm hesitant to submit it to vcpkg on behalf of the upstream maintainer (h2o/picohttpparser). Would the vcpkg team be willing to create the picohttpparser port? It's very small — just 2 files (~800 lines), MIT licensed. I can provide my overlay port as a starting point. Alternatively, if you'd prefer I include it directly in this PR, I'm happy to do so. Just let me know which approach you prefer. |
|
Follow-up regarding the picohttpparser port: I have a working overlay port ready (CMakeLists.txt + portfile.cmake), since upstream h2o/picohttpparser doesn't provide a CMakeLists.txt. However, I'm hesitant to submit a port for this library to vcpkg on behalf of the upstream maintainer. Would the vcpkg team be open to creating the picohttpparser port? It's very small — just 2 files (~800 lines), MIT licensed. I'm happy to provide my overlay port as a starting point. If you'd prefer I include it directly in this PR instead, that works too — just let me know. |
- Update SHA512 for v2.6.1 release - Add picohttpparser dependency (port merged in microsoft#51743) - Pass -DHICAL_USE_SYSTEM_PICOHTTPPARSER=ON - Remove boost-beast dependency (replaced by native HTTP/WebSocket stack)
f86181d to
db353b6
Compare
Changes
Update
hical61-hicalto version 2.6.1.Upstream release: https://github.com/Hical61/Hical/releases/tag/v2.6.1
Port changes
versionto2.6.1invcpkg.jsonSHA512inportfile.cmakeboost-beastdependency (replaced by native HTTP/WebSocket stack)picohttpparserdependency (port merged in [picohttpparser] Add new port, devendor from [cinatra] #51743)zlibdependency (required for WebSocket permessage-deflate)-DHICAL_USE_SYSTEM_PICOHTTPPARSER=ONbuild optiondescriptionto reflect native stackChecklist
./vcpkg x-add-version --alland committing the result.