[fltk] Revise by dg0yt · Pull Request #51569 · microsoft/vcpkg

dg0yt · 2026-05-06T03:24:18Z

Somehwat improve the dependency import/export mess, hopefully reducing vcpkg baseline regressions.

BillyONeal · 2026-05-06T03:27:21Z

Repeating relevant information here since this PR is open and that one is closed:

ninja: error: '/usr/lib/x86_64-linux-gnu/libXft.so', needed by 'utils/mglview', missing and no known rule to make it

/usr/bin/ld: cannot find -lXft: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:13119: libinterp/dldfcn/__fltk_uigetfile__.la] Error 1
make[2]: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lXft: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:13131: libinterp/dldfcn/__init_fltk__.la] Error 1
make[1]: *** [Makefile:28742: all-recursive] Error 1
make: *** [Makefile:11735: all] Error 2

In the broken run fltk had package abi 4cba3965e0f7fcf2771ed15737dad6542d9b28abded996e677bb9825d8994b13

dg0yt · 2026-05-06T03:30:06Z

+ endif (X11_Xft_FOUND)
+
+ if (OPTION_USE_XFT)
+-  set (USE_XFT X11_Xft_FOUND)


NB a literal X11_Xft_FOUND, not the value.
But it shouldn't get there without X11_Xft_FOUND.

dg0yt · 2026-05-06T06:10:46Z

'/usr/lib/x86_64-linux-gnu/libXft.so'

IMO this path should only be produce by find_library in FindX11.cmake in fltk, and eventually it is stored in fltk-config. It is really strange that it ends up in a downstream ninja rule and is reported as missing in the same CI run.

dg0yt · 2026-05-06T17:36:01Z

/usr/lib/x86_64-linux-gnu/libXft.so is exported from fltk, but AFAICT it shouldn't exist in the image used in CI.

/mnt/vcpkg-ci/installed/x64-linux/share/fltk/FLTK-Targets.cmake(64):  set_target_properties(fltk PROPERTIES INTERFACE_INCLUDE_DIRECTORIES /mnt/vcpkg-ci/installed/x64-linux/include INTERFACE_LINK_LIBRARIES dl;/usr/lib/x86_64-linux-gnu/libSM.so;/usr/lib/x86_64-linux-gnu/libICE.so;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXinerama.so;/usr/lib/x86_64-linux-gnu/libXfixes.so;/usr/lib/x86_64-linux-gnu/libXcursor.so;/usr/lib/x86_64-linux-gnu/libXrender.so;/usr/lib/x86_64-linux-gnu/libXft.so;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libfontconfig.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libfontconfig.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libfreetype.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libfreetyped.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libz.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libz.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libbz2.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libbz2d.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libpng16.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libpng16d.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libz.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libz.a>;m;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libbrotlidec.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libbrotlidec.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libbrotlicommon.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libbrotlicommon.a>;$<$<NOT:$<CONFIG:DEBUG>>:/mnt/vcpkg-ci/installed/x64-linux/lib/libexpat.a>;$<$<CONFIG:DEBUG>:/mnt/vcpkg-ci/installed/x64-linux/debug/lib/libexpat.a> )

BillyONeal · 2026-05-06T17:40:06Z

4cba3965e0f7fcf2771ed15737dad6542d9b28abded996e677bb9825d8994b13.zip

dg0yt · 2026-05-06T18:09:08Z

fltk[core] does not give an indication that it finds libXft.

/mnt/vcpkg-ci/b/fltk/src/ase-1.3.11-61ddd0adce.clean/src/CMakeLists.txt(309):  target_link_libraries(fltk dl;/usr/lib/x86_64-linux-gnu/libSM.so;/usr/lib/x86_64-linux-gnu/libICE.so;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXinerama.so;/usr/lib/x86_64-linux-gnu/libXfixes.so;/usr/lib/x86_64-linux-gnu/libXcursor.so;/usr/lib/x86_64-linux-gnu/libXrender.so )

BillyONeal · 2026-05-06T18:22:16Z

The broken one indeed has:

set_target_properties(fltk PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "dl;/usr/lib/x86_64-linux-gnu/libSM.so;/usr/lib/x86_64-linux-gnu/libICE.so;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXinerama.so;/usr/lib/x86_64-linux-gnu/libXfixes.so;/usr/lib/x86_64-linux-gnu/libXcursor.so;/usr/lib/x86_64-linux-gnu/libXrender.so;/usr/lib/x86_64-linux-gnu/libXft.so;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libfontconfig.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libfontconfig.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libfreetype.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libfreetyped.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libz.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libz.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbz2.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbz2d.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libpng16.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libpng16d.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libz.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libz.a>;m;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbrotlidec.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbrotlidec.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbrotlicommon.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbrotlicommon.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libexpat.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libexpat.a>"
)

dg0yt · 2026-05-06T18:32:19Z

fltk[core,opengl] does:

target_link_libraries(fltk dl;/usr/lib/x86_64-linux-gnu/libSM.so;/usr/lib/x86_64-linux-gnu/libICE.so;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXinerama.so;/usr/lib/x86_64-linux-gnu/libXfixes.so;/usr/lib/x86_64-linux-gnu/libXcursor.so;/usr/lib/x86_64-linux-gnu/libXrender.so )

but @BillyONeal's zip comes with this result in FLTK-Targets.cmake:

set_target_properties(fltk PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "dl;/usr/lib/x86_64-linux-gnu/libSM.so;/usr/lib/x86_64-linux-gnu/libICE.so;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libXinerama.so;/usr/lib/x86_64-linux-gnu/libXfixes.so;/usr/lib/x86_64-linux-gnu/libXcursor.so;/usr/lib/x86_64-linux-gnu/libXrender.so;/usr/lib/x86_64-linux-gnu/libXft.so;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libfontconfig.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libfontconfig.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libfreetype.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libfreetyped.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libz.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libz.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbz2.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbz2d.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libpng16.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libpng16d.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libz.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libz.a>;m;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbrotlidec.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbrotlidec.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libbrotlicommon.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libbrotlicommon.a>;\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libexpat.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libexpat.a>"
)

i.e. after libXrender comes libXft with its chain of usage requirements (via fontconfig and freetype).

dg0yt · 2026-05-06T18:38:07Z

Synchronizing posts...

dg0yt · 2026-05-07T04:29:33Z

And then it is gone again.

BillyONeal · 2026-05-07T07:47:40Z

BillyONeal

Thanks!

[fltk] Revise

33bc95e

dg0yt mentioned this pull request May 6, 2026

[lerc] Update to 4.1 #51530

Merged

WIP

a7cc9ec

dg0yt commented May 6, 2026

View reviewed changes

trace

fdba391

Trace [skip actions]

d34e666

Trace [skip actions]

c1a7340

dg0yt added 2 commits May 6, 2026 22:16

fltk

a9e753b

Finish

5e97da8

dg0yt added 2 commits May 7, 2026 17:42

CI

1c8db08

baseline

57b9a76

dg0yt marked this pull request as ready for review May 7, 2026 16:17

BillyONeal approved these changes May 7, 2026

View reviewed changes

BillyONeal merged commit 4bc07e3 into microsoft:master May 7, 2026
16 checks passed

dg0yt deleted the fltk branch May 7, 2026 19:16

This was referenced Jun 5, 2026

[sqlite3] Update to 3.53.2 #52182

Merged

[fltk] GPT Attempts fixing Linux FLTK metadata paths #52220

Closed

Uh oh!

Conversation

dg0yt commented May 6, 2026

Uh oh!

BillyONeal commented May 6, 2026

Uh oh!

dg0yt May 6, 2026

Choose a reason for hiding this comment

Uh oh!

dg0yt commented May 6, 2026

Uh oh!

dg0yt commented May 6, 2026

Uh oh!

BillyONeal commented May 6, 2026

Uh oh!

dg0yt commented May 6, 2026

Uh oh!

BillyONeal commented May 6, 2026

Uh oh!

dg0yt commented May 6, 2026

Uh oh!

dg0yt commented May 6, 2026

Uh oh!

dg0yt commented May 7, 2026

Uh oh!

BillyONeal commented May 7, 2026

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants