[vxl] Fix conflict with Intel libvpl#51516
Merged
Merged
Conversation
Merge devendor.diff + openjpeg.diff + (this change)-> devendor-and-conflicts.diff as these are all about conflicts between this and other ports and touch the same areas. Rename file_formats.diff -> file-formats.diff for consistent -s.
7 tasks
Contributor
|
Thanks for cleaning up the mess. |
Merged
BillyONeal
commented
May 4, 2026
| if( GEOTIFF_FOUND ) | ||
| set(VXL_USING_NATIVE_GEOTIFF "YES") | ||
| endif() | ||
| diff --git a/config/cmake/Modules/FindOpenJPEG2.cmake b/config/cmake/Modules/FindOpenJPEG2.cmake |
Member
Author
There was a problem hiding this comment.
This hunk came from openjpeg.diff
BillyONeal
commented
May 4, 2026
| USE_HIDDEN_VISIBILITY | ||
| ) | ||
|
|
||
| +set_target_properties(${VXL_LIB_PREFIX}vpl PROPERTIES OUTPUT_NAME vxl_vpl) # avoid conflict with Intel libvpl |
Member
Author
There was a problem hiding this comment.
This is the "meat" of the change
BillyONeal
commented
May 4, 2026
| endif() | ||
| mark_as_advanced(VXL_MATH_LIBRARY_FOUND) | ||
| set_target_properties(openjpeg2 PROPERTIES | ||
| + OUTPUT_NAME vxl_openjpeg |
Member
Author
There was a problem hiding this comment.
This hunk came from openjpeg.diff
vicroms
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge devendor.diff + openjpeg.diff + (this change)-> devendor-and-conflicts.diff as these are all about conflicts between this and other ports and touch the same areas.
Rename file_formats.diff -> file-formats.diff for consistent -s.