[gdal] Fix with current CMake.#51410
Conversation
Remove fix-gdal-target-interfaces because it was applied upstream in OSGeo/gdal@f63b63e Regenerate patches. Don't install FindSQLite3.cmake which breaks all SQLite customers expecting to use SQLite3::SQLite3. (I tried to apply OSGeo/gdal@1eb29fb but it does not apply cleanly, and it seems wrong to be replacing a built in find module like this for unrelated customers anyway)
|
I was hoping to get away with just yanking this but it looks like it broke things in the opposite direction for arm-neon-android, so I guess I need to patch their override to create the correct targets. IMO it is unacceptable that we ever let GDAL do this but too late to go back now. |
|
The vendored FindSQLite3.cmake has been troublesome before. That's why it wasn't removed by the port. |
|
IIUC the update patch files are unchanged except for line numbers. |
|
What GDAL needs for SQLite3 in CMake 4.3 is adapting to the new imported target created Kitware's FindSQLite3.cmake. |
It passed my initial test on Windows.
I took the ones where line numbers changed but not where only SHAs changed. Sometimes a closer line number is helpful in future updates when the patch doesn't apply cleanly.
Yeah, and I think there's already an upstream commit for it. I wanted to try removing it first but I guess I can't :(. |
Using default linkage? On Windows, it hides the pain of transitive dependencies. I started vcpkg with months of fixing #9068. |
I mean, it seemed like it. |
…f the custom find module.
|
There was an error handling pipeline event 2d95fb5c-3814-4825-9aae-82fb3df0e28e. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Remove fix-gdal-target-interfaces because it was applied upstream in OSGeo/gdal@f63b63e (by @dg0yt )
Regenerate patches. If the only diff was "SHA-ish" I reverted it but if there were line number changes I took it.
Make gdal's FindSQLite module it hijacks the world with create the CMake 4.3+
SQLite3::SQLite3target in addition to theSQLite::SQLite3one.This fixes the gz-common failures in #51210