Skip to content

[kguiaddons] Control QML support, fix install locations#51381

Merged
BillyONeal merged 1 commit into
microsoft:masterfrom
ajtribick:kguiaddons-fixes
Apr 26, 2026
Merged

[kguiaddons] Control QML support, fix install locations#51381
BillyONeal merged 1 commit into
microsoft:masterfrom
ajtribick:kguiaddons-fixes

Conversation

@ajtribick

@ajtribick ajtribick commented Apr 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@ajtribick ajtribick mentioned this pull request Apr 25, 2026
Merged
7 tasks
@ajtribick ajtribick marked this pull request as ready for review April 25, 2026 15:56
@Osyotr Osyotr mentioned this pull request Apr 25, 2026
Merged
7 tasks
@BillyONeal

BillyONeal commented Apr 26, 2026

Copy link
Copy Markdown
Member

Hi there! Thanks for the fix! Can you explain how this actually fixes it? (It's not obvious how controlling this dependency fixes putting the bits in the wrong place)

Installing 1359/2711 kguiaddons:arm64-windows@6.25.0...
kguiaddons:arm64-windows@6.25.0 package ABI: 95f633eccc647d50ca7d27e8dbb2e9142eb443471f293558f689c1311686d426
Building kguiaddons:arm64-windows@6.25.0...
Trying to download KDE-kguiaddons-v6.25.0.tar.gz using asset cache https://vcpkgassetcachewus.blob.core.windows.net/cache/ad221061698fea27e354ce2be0ec565fd70850add9964c306d415c4cc95b68d09c0c217fde1e45f0ad668a13e93b2a5e2d0059a6bfb514b1cea6f37d4ac01a0f?*** SECRET ***
Download successful! Asset cache hit, did not try authoritative source https://github.com/KDE/kguiaddons/archive/v6.25.0.tar.gz
-- Extracting source D:/downloads/KDE-kguiaddons-v6.25.0.tar.gz
-- Using source at D:/b/kguiaddons/src/v6.25.0-e3bb7077c6.clean
-- Configuring arm64-windows
-- Building arm64-windows-dbg
-- Building arm64-windows-rel
-- Performing post-build validation
D:\a\_work\1\s\ports\kguiaddons\portfile.cmake: warning: The following dlls were found in ${CURRENT_PACKAGES_DIR}/lib or ${CURRENT_PACKAGES_DIR}/debug/lib. Please move them to ${CURRENT_PACKAGES_DIR}/bin or ${CURRENT_PACKAGES_DIR}/debug/bin, respectively.
D:\p\kguiaddons_arm64-windows: note: the DLLs are relative to ${CURRENT_PACKAGES_DIR} here
note: debug/lib/qml/org/kde/guiaddons/kguiaddonsqml.dll
note: lib/qml/org/kde/guiaddons/kguiaddonsqml.dll
D:\a\_work\1\s\ports\kguiaddons\portfile.cmake: warning: Found 1 post-build check problem(s). These are usually caused by bugs in portfile.cmake or the upstream build system. Please correct these before submitting this port to the curated registry.
error: building kguiaddons:arm64-windows failed with: POST_BUILD_CHECKS_FAILED
See https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Elapsed time to handle kguiaddons:arm64-windows: 29 s
Completed submission of keystone:arm64-windows@0.9.2#4 to 1 binary cache(s) in 3.1 s

BillyONeal
BillyONeal approved these changes Apr 26, 2026
View reviewed changes

@BillyONeal BillyONeal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would like it on record how this fixes it but I'm going to merge this anyway because even if it doesn't fix the CI problem it's an improvement anyway.

@BillyONeal BillyONeal merged commit 938c6c0 into microsoft:master Apr 26, 2026
16 checks passed
ajtribick
ajtribick commented Apr 26, 2026
View reviewed changes
Comment thread ports/kguiaddons/portfile.cmake
OPTIONS
-DBUILD_TESTING=OFF
-DBUILD_PYTHON_BINDINGS=OFF
-DKDE_INSTALL_QMLDIR=qml

@ajtribick ajtribick Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal - the QML file location is fixed here (-DKDE_INSTALL_QMLDIR): this matches the other KDE ports.

ajtribick
ajtribick commented Apr 26, 2026
View reviewed changes
Comment thread ports/kguiaddons/vcpkg.json
"default-features": false
"default-features": false,
"features": [
"gui"

@ajtribick ajtribick Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build with vcpkg install qtbase[core] kguiaddons - Qt6Gui is a required dependency in the kguiaddons CMakeLists.txt file: https://github.com/KDE/kguiaddons/blob/bfc94ffa0487702052b5e0ef9adf740cac349386/CMakeLists.txt#L43

ajtribick
ajtribick commented Apr 26, 2026
View reviewed changes
Comment thread ports/kguiaddons/portfile.cmake
file(WRITE "${SOURCE_PATH}/.clang-format" "DisableFormat: true\nSortIncludes: false\n")

if(NOT "qml" IN_LIST FEATURES)
list(APPEND FEATURE_OPTIONS "-DCMAKE_DISABLE_FIND_PACKAGE_Qt6Qml=ON")

@ajtribick ajtribick Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kguiaddons switches on qml support based on whether the Qt6::Qml target is found: https://github.com/KDE/kguiaddons/blob/bfc94ffa0487702052b5e0ef9adf740cac349386/src/CMakeLists.txt#L243-L245

@ajtribick ajtribick deleted the kguiaddons-fixes branch April 26, 2026 06:08
@BillyONeal BillyONeal mentioned this pull request Apr 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajtribick @BillyONeal