Improve version database consistency check#51374
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This was referenced Apr 25, 2026
Member
Author
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the “Check For Common Mistakes” GitHub Actions workflow to make the version database consistency check stricter and the resulting guidance more actionable for contributors updating the versions/ database.
Changes:
- Reworks the version-db verification to reset
versions/to the PR merge-base and re-runvcpkg x-add-versionto detect whitespace/sort-order issues and multi-version edits. - Improves CI feedback by moving generated diffs into the workflow summary and updating remediation instructions.
- Updates the workflow runner to
ubuntu-latest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vicroms
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In writing the PR comment #51353 (comment) I nerd sniped myself to improve the "check for common mistakes" check to emit better instructions for updating the version database.
Fixes / changes:
x-add-versionin the merge-base versions directory contents andx-add-versionwill only ever add one version, so there will be a diff if the user added more than one.x-add-version, which means there is no need to conditionally--overwrite-versionor similar. Moreover, this will generate warnings if they editedport-versionmore than once in a PR or similar.This hopefully shuts down accidentally merging changes like #51110 which cause whitespace diffs in many subsequent changes like happened in #51272
Demonstration: #51372
Demonstration: #51373
/cc @autoantwort @dg0yt