Skip to content

[simpleble] Revise#51288

Merged
BillyONeal merged 3 commits into
microsoft:masterfrom
dg0yt:simpleble
Apr 21, 2026
Merged

[simpleble] Revise#51288
BillyONeal merged 3 commits into
microsoft:masterfrom
dg0yt:simpleble

Conversation

@dg0yt

@dg0yt dg0yt commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Really devendor fmt and nanopb.
Provide PKG_CONFIG.

@miyanyan

Copy link
Copy Markdown
Contributor

just curious about why license was removed in #49173

@dg0yt

dg0yt commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

just curious about why license was removed in #49173

Hm, reviewers should have asked at that time. But we can restore it now.

@BillyONeal

Copy link
Copy Markdown
Member

just curious about why license was removed in #49173

I guess I'm just used to upstreams being all crazy with their licenses. Either way, the old license GPL3 was incorrect. Thank you @dg0yt for putting on what at least appears to be a correct license.

@BillyONeal BillyONeal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@BillyONeal BillyONeal merged commit 40679b2 into microsoft:master Apr 21, 2026
16 checks passed
@dg0yt dg0yt deleted the simpleble branch April 21, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants