[mimalloc] Install minject tool on windows platform#51244
Merged
Conversation
BillyONeal
approved these changes
Apr 21, 2026
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/mimalloc) | ||
|
|
||
| if(VCPKG_TARGET_IS_WINDOWS) | ||
| file(INSTALL |
Member
There was a problem hiding this comment.
Q: Should this use vcpkg_copy_tools?
A: No, that's relative to SOURCE_PATH not CURRENT_PACKAGES_DIR.
No change requested.
Contributor
There was a problem hiding this comment.
minject is a vendored closed-source static executable.
vcpkg_copy_tools can handle other locations, but it is pointless for static tools.
Member
There was a problem hiding this comment.
Yeah that's the conclusion I came to but because I had the question I figured I should have it on record that I considered it before pushing the merge button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add installation of the minject tool on Windows. The minject executables are provided by mimalloc and can be used to injects the mimalloc dll and ensures that it comes first in the import table.
./vcpkg x-add-version --alland committing the result.