[robotraconteur-companion] Add patch to fix eigen3 5 version in cmake package config files#51231
Merged
BillyONeal merged 2 commits intoApr 20, 2026
Conversation
dg0yt
reviewed
Apr 18, 2026
Comment on lines
+9
to
+13
| -find_package(Eigen3 3.3 REQUIRED NO_MODULE) | ||
| +find_package(Eigen3 3.3 NO_MODULE QUIET) | ||
| +if(NOT Eigen3_FOUND) | ||
| + find_package(Eigen3 3.3...<6 REQUIRED NO_MODULE) | ||
| +endif() |
Contributor
There was a problem hiding this comment.
Integrate the change, and align the approach, with 0001-support-eigen3-5.patch. It is one topic.
3c59768 to
0eb192f
Compare
Contributor
Author
|
I updated the patch as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.This PR adds a patch to the
robotraconteur-companionpackage to fix findingeigen3version 5 or higher in the cmake package configuration files.