[stescobedo92-stellar] new port, version 0.1.0#51213
Merged
Merged
Conversation
2360296 to
b227bc4
Compare
b227bc4 to
2d46395
Compare
* Remove usage * Disable warnings * Remove unnecessary json fields
BillyONeal
requested changes
Apr 18, 2026
BillyONeal
left a comment
Member
There was a problem hiding this comment.
Unfortunately the name "stellar" is already associated in repology ( https://repology.org/project/stellar/versions ) which points to https://github.com/fastmonkeys/stellar rather than https://github.com/stescobedo92/stellar . I think that means we need to use the "githuborg-repo" pattern for the name.
GPT 5.4 pointed out that this leaks warning settings into the interface target, repeating its statement:
Other Port Review Suggestions
- Suggestion: disable exported warning flags during packaging
- Evidence: upstream defines
option(STELLAR_ENABLE_WARNINGS ... ON)and applies warning flags to theINTERFACEtarget (buildtrees\stellar\src\v0.1.0-1e8436a169.clean\CMakeLists.txt:13,38-43). The installed export preserves them asINTERFACE_COMPILE_OPTIONS "/W4;/permissive-;/Zc:__cplusplus;/Zc:preprocessor"(packages\stellar_arm64-windows\share\stellar\stellarTargets.cmake:60-64).- Rationale: because
stellaris header-only and exported as an imported interface target, consumers inherit these warning settings automatically. That is usually undesirable for vcpkg packages and can create build noise or policy conflicts in downstream projects.
I think I fixed these in: stescobedo92#2
Comment on lines
+6
to
+7
| "homepage": "https://github.com/stescobedo92/stellar", | ||
| "documentation": "https://github.com/stescobedo92/stellar#readme", |
Member
There was a problem hiding this comment.
Suggested change
| "homepage": "https://github.com/stescobedo92/stellar", | |
| "documentation": "https://github.com/stescobedo92/stellar#readme", | |
| "homepage": "https://github.com/stescobedo92/stellar", |
| @@ -0,0 +1,4 @@ | |||
| stellar provides CMake targets: | |||
Member
There was a problem hiding this comment.
This is more or less equivalent to the default generated usage so we shouldn't add a custom one.
Comment on lines
+2
to
+3
| "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json", | ||
| "name": "stellar", |
Member
There was a problem hiding this comment.
Suggested change
| "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json", | |
| "name": "stellar", | |
| "name": "stellar", |
Resolve code review suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new port
stellar— a header-only C++23 toolkit (ste::) for string manipulation, collection utilities, StringBuilder and async (std::future + coroutines).What's tested
vcpkg install stellarverified locally with the port in this PRChecklist
./vcpkg x-add-version --alland committing the result.