[consteig] Add consteig 1.0.0#50827
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
vicroms
requested changes
Mar 30, 2026
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO MitchellThompkins/consteig | ||
| REF "1.0.0" |
Member
There was a problem hiding this comment.
Suggested change
| REF "1.0.0" | |
| REF "{VERSION}" |
If this matches the version in vcpkg.json, we can make this change to simplify changes in the future.
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DCONSTEIG_VERSION=1.0.0 |
Member
There was a problem hiding this comment.
Suggested change
| -DCONSTEIG_VERSION=1.0.0 | |
| -DCONSTEIG_VERSION="${VERSION}" |
Ensures that the version doesn't get desynchronized if someone forgets to update this line.
| ) | ||
|
|
||
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(PACKAGE_NAME consteig CONFIG_PATH lib/cmake/consteig) |
Member
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_config_fixup(PACKAGE_NAME consteig CONFIG_PATH lib/cmake/consteig) | |
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/consteig) |
PACKAGE_NAME is not necessary in this case.
vicroms
approved these changes
Apr 6, 2026
dg0yt
reviewed
Apr 12, 2026
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DCONSTEIG_VERSION="${VERSION}" |
Contributor
There was a problem hiding this comment.
Proper quote for CMake language:
Suggested change
| -DCONSTEIG_VERSION="${VERSION}" | |
| "-DCONSTEIG_VERSION=${VERSION}" |
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/consteig) | ||
|
|
||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug") |
Contributor
There was a problem hiding this comment.
Not in a release-only build.
Suggested change
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug") |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.