[lerc] update to 4.1.1#50592
Closed
toge wants to merge 2 commits into
Closed
Conversation
dg0yt
reviewed
Mar 23, 2026
Comment on lines
+26
to
+32
| @@ -9,5 +9,5 @@ URL: @PROJECT_HOMEPAGE_URL@ | ||
| Version: @PROJECT_VERSION@ | ||
| Cflags: -I${includedir} | ||
| Cflags.private: -DLERC_STATIC | ||
| -Libs: -L${libdir} -lLerc | ||
| +Libs: -L${libdir} -lLerc @FAKE_CXX_LINKAGE@ | ||
| Libs.private: -lstdc++ |
Contributor
There was a problem hiding this comment.
The patch was already smarter than upstream. There is no libstdc++ on some targets.
Suggested change
| @@ -9,5 +9,5 @@ URL: @PROJECT_HOMEPAGE_URL@ | |
| Version: @PROJECT_VERSION@ | |
| Cflags: -I${includedir} | |
| Cflags.private: -DLERC_STATIC | |
| -Libs: -L${libdir} -lLerc | |
| +Libs: -L${libdir} -lLerc @FAKE_CXX_LINKAGE@ | |
| Libs.private: -lstdc++ | |
| @@ -10,4 +10,4 @@ URL: @PROJECT_HOMEPAGE_URL@ | |
| Cflags: -I${includedir} | |
| Cflags.private: -DLERC_STATIC | |
| Libs: -L${libdir} -lLerc | |
| -Libs.private: -lstdc++ | |
| +Libs.private: @FAKE_CXX_LINKAGE@ |
dg0yt
reviewed
Mar 23, 2026
Comment on lines
14
to
16
| + string(APPEND FAKE_CXX_LINKAGE " ${CMAKE_LINK_LIBRARY_FILE_FLAG}${lib}") | ||
| + else() | ||
| + string(APPEND FAKE_CXX_LINKAGE " ${CMAKE_LINK_LIBRARY_FLAG}${lib}") |
Contributor
There was a problem hiding this comment.
BTW today I would change it to
Suggested change
| + string(APPEND FAKE_CXX_LINKAGE " ${lib}") | |
| + else() | |
| + string(APPEND FAKE_CXX_LINKAGE " -l${lib}") |
because (our) pc files use gcc style options everywhere.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/Esri/lerc/releases/tag/js_v4.1.1