Skip to content

[Catch2] Include *.pdb files in Catch2 port#49707

Merged
JavierMatosD merged 1 commit into
microsoft:masterfrom
tobiasleibner:catch2_copy_pdbs
Feb 25, 2026
Merged

[Catch2] Include *.pdb files in Catch2 port#49707
JavierMatosD merged 1 commit into
microsoft:masterfrom
tobiasleibner:catch2_copy_pdbs

Conversation

@tobiasleibner

@tobiasleibner tobiasleibner commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Without this change, we are getting

warning LNK4099: PDB 'catch.pdb' was not found with 'catch2.lib'; linking object as if no debug info

warnings when depending on Catch2.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BillyONeal

BillyONeal commented Feb 4, 2026

Copy link
Copy Markdown
Member

PR build failures are due to missing vcpkg.json edits; it looks like you edited that before running vcpkg x-add-version but forgot to git add it.

I won't try to submit a fix because we're waiting for a CLA signing anyway.

@tobiasleibner

tobiasleibner commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Arup"

@tobiasleibner tobiasleibner changed the title Add vcpkg_copy_pdbs to Catch2 port Include *.pdb files in Catch2 port Feb 25, 2026
@tobiasleibner tobiasleibner marked this pull request as ready for review February 25, 2026 14:52
@JavierMatosD JavierMatosD merged commit 9ffe8dc into microsoft:master Feb 25, 2026
15 checks passed
@tobiasleibner tobiasleibner deleted the catch2_copy_pdbs branch February 25, 2026 15:56
@tobiasleibner tobiasleibner changed the title Include *.pdb files in Catch2 port [Catch2] Include *.pdb files in Catch2 port Feb 25, 2026
@tobiasleibner tobiasleibner mentioned this pull request Feb 25, 2026
Closed
7 tasks
@JavierMatosD

JavierMatosD commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

I think I need to revert this https://github.com/microsoft/vcpkg/pull/50171/changes#r2854844058

@BillyONeal

BillyONeal commented Feb 25, 2026

Copy link
Copy Markdown
Member

I think I need to revert this https://github.com/microsoft/vcpkg/pull/50171/changes#r2854844058

I don't think it needs a panic revert but I do think the right change is /Z7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JavierMatosD JavierMatosD JavierMatosD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasleibner @BillyONeal @JavierMatosD