[libpq] Fix x64-linux build (#48024)#49238
Closed
jobor wants to merge 1 commit into
Closed
Conversation
302a636 to
3d613db
Compare
vicroms
reviewed
Jan 6, 2026
Comment on lines
+109
to
+116
| if(NOT VCPKG_TARGET_IS_WINDOWS) | ||
| # Pass the location of timezone data. This is necessary, because | ||
| # fix-configure.patch sets cross_compiling=yes to avoid conftest issues. | ||
| set(TZDATA_PATH "/usr/share/zoneinfo") | ||
| if(EXISTS "${TZDATA_PATH}") | ||
| list(APPEND BUILD_OPTS --with-system-tzdata=${TZDATA_PATH}) | ||
| endif() | ||
| endif() |
Member
There was a problem hiding this comment.
Having hardcoded paths in a portfile feels incorrect, perhaps this should be set by a triplet variable or the build modified so this is not necessary.
Contributor
Author
There was a problem hiding this comment.
I've changed the patch such that the path is overridable with a triplet variable.
Configure with --with-system-tzdata on non-Windows systems if /usr/share/zoneinfo exists. The tzdata location can be overridden by the triplet variable VCPKG_SYSTEM_TZDATA_PATH. The port forces configure to think that it's crosscompiling, and that requires a zic executable or already available tzdata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure with --with-system-tzdata on non-Windows systems if /usr/share/zoneinfo exists.
The port forces configure to think that it's crosscompiling, and that requires a zic executable or already available tzdata.
Fixes #48024