Skip to content

[WIP][vtk] add the option -DModule_vtkGUISupportMFC=ON#4661

Merged
Rastaban merged 4 commits intomicrosoft:masterfrom
MouhammadEV:patch-2
Mar 18, 2019
Merged

[WIP][vtk] add the option -DModule_vtkGUISupportMFC=ON#4661
Rastaban merged 4 commits intomicrosoft:masterfrom
MouhammadEV:patch-2

Conversation

@MouhammadEV
Copy link
Copy Markdown
Contributor

No description provided.

@msftclas
Copy link
Copy Markdown

msftclas commented Nov 6, 2018

CLA assistant check
All CLA requirements met.

@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for the PR!

When I build vtk in this PR for x64-windows or x64-windows-static, I get the following error:

C:\vsts_work\1\s\buildtrees\vtk\src\v8.1.0-3e8db5da7b\GUISupport\MFC\vtkMFCWindow.cpp(195): error C2661: 'vtkOpenGLRenderWindow::GetPixelData': no overloaded function takes 5 arguments

This is with the latest VS2017.

Could you take a look at this or confirm that it doesn't repro for you? You may also want to purge the buildtrees\vtk\ directory just to make sure you're working from clean sources.

@MouhammadEV
Copy link
Copy Markdown
Contributor Author

MouhammadEV commented Nov 9, 2018

Yes .. I got also this error while trying to compile the vtk library.
However this problem was solved in the new version (8.2.0.rc1). But this version is not yet released on git.
As a walkaround you could change the line 195 in the file: vtkMFCWindow.cpp to:
this->pvtkWin32OpenGLRW->GetPixelData(0,0,size[0]-1,size[1]-1,0,0);
That should do the trick.

@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Nov 9, 2018

I definitely can't merge this without vcpkg install vtk building cleanly by default; I think this means we need to wait on this PR until 8.2.0 is fully released.

@ras0219-msft ras0219-msft changed the title add the option -DModule_vtkGUISupportMFC=ON [WIP - waiting for vtk release 8.2.0] add the option -DModule_vtkGUISupportMFC=ON Nov 14, 2018
@luzpaz
Copy link
Copy Markdown
Contributor

luzpaz commented Jan 31, 2019

JFYI, Vtk 8.2.0 was released: https://blog.kitware.com/vtk-8-2-0/

@luzpaz
Copy link
Copy Markdown
Contributor

luzpaz commented Feb 13, 2019

Any progress on this ? Thanks!

@Rastaban Rastaban self-assigned this Feb 25, 2019
@Rastaban Rastaban mentioned this pull request Feb 26, 2019
@Rastaban Rastaban added the wip label Feb 27, 2019
@Rastaban Rastaban changed the title [WIP - waiting for vtk release 8.2.0] add the option -DModule_vtkGUISupportMFC=ON [WIP][vtk] add the option -DModule_vtkGUISupportMFC=ON Mar 15, 2019
@Rastaban
Copy link
Copy Markdown
Contributor

vtk had been updated in vcpkg to 8.2.0, Resolved merge conflict.

@Rastaban Rastaban merged commit aed7d2e into microsoft:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants