[rtabmap] update to 0.23.2#46422
Merged
BillyONeal merged 17 commits intomicrosoft:masterfrom Nov 3, 2025
Merged
Conversation
Contributor
|
I suggest to do the update after finishing revising/fixing this port and its dependencies (g2o, realsense) in #46385. I reduce patching, intentionally. |
Contributor
Author
|
Putting back into draft mode till #46385 is merged. I'll re-update this PR afterwards. |
Contributor
|
#46385 was merged now. |
Contributor
Author
|
|
Contributor
Maybe it is not activating the right section here: Not sure if this is a good condition at all. They shouldn't care about vcpkg-specific adapations. And I see |
Contributor
Author
|
Thanks to point it out. g2o doesn't publish any version, so there are many hacky ways to read specific stuff in their headers to "know" approximately which version it is. In rtabmap, we added WIN32 as a way to detect vcpkg in windows, though it may not work on other platforms. I am not sure why the vcpkg port of g2o is removing that line: vcpkg/ports/g2o/fix-absolute.patch Line 19 in 71f1234 or, which should be || indeed. Thanks for reviewing!
EDIT: actually, on my computer (Visual Studio 2022) the |
Contributor
You could simply add a CMake option, or do a try_compile (which comes with an implicit option). |
Contributor
We cannot hard-code any absolute paths in installed files, and we cannot rely on any build-time directories to be present after installation. Binary packages are cached, and they might be restored in different locations or even on different machines. |
Contributor
Note that the port had a vcpkg-specific patch working for any platform, and removing the patch shouldn't cause regressions. |
Contributor
Author
|
It seems all issues on rtabmap port are fixed, tohugh CI is failing when building opencv: rtabmap doesn't need DNN module from opencv, I'll check to remove that dependency. Then another config error when searching for OpenMP on osx: I'll doublecheck if it is new stuff from latest version that could explain why there were no patches for that before. |
Contributor
Author
|
Updating with latest master seem to have fix all build issues. Ready for another round of review. |
dg0yt
reviewed
Nov 2, 2025
Contributor
dg0yt
left a comment
There was a problem hiding this comment.
LGTM, but someone else must approve.
BillyONeal
approved these changes
Nov 3, 2025
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for the update and evaporating all those patches!
I want to give @cenit a couple days to respond on the one removed patch.
Contributor
sorry I just had some time now. OK for me, unfortunately with such a small contribution on my side I cannot say anything different. I don't know how much of the catalogue is still buildable overriding "opencv" generic port to point to opencv3 and not 4, it was 100% last time i had some time and I was on it (a long time ago) |
Member
That's fine! I just wanted to make sure you wouldn't be angry due to removing a patch you added and the PR that added it wasn't super clear about why. Thanks for following up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.