[glew] Add public definition GLEW_NO_GLU [colmap] Remove feature cuda#43641
Closed
WangWeiLin-MV wants to merge 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/freetype-gl/system-dependency-message
Closed
[glew] Add public definition GLEW_NO_GLU [colmap] Remove feature cuda#43641WangWeiLin-MV wants to merge 1 commit intomicrosoft:masterfrom WangWeiLin-MV:ports/freetype-gl/system-dependency-message
WangWeiLin-MV wants to merge 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/freetype-gl/system-dependency-message
Conversation
JonLiu1993
approved these changes
Feb 6, 2025
dg0yt
reviewed
Feb 6, 2025
Contributor
|
GLEW doesn't use GLU. |
Contributor
i.e. not in CMake. Then you don't have to patch downstream ports. |
JonLiu1993
approved these changes
Feb 8, 2025
Contributor
|
Approved? Okay, suggestion implemented in #43695. |
dg0yt
reviewed
Feb 8, 2025
Contributor
dg0yt
left a comment
There was a problem hiding this comment.
Really don't see this as ready to merge.
| ${FREETYPE_LIBRARIES} | ||
| ${MATH_LIBRARY} | ||
| - ${GLEW_LIBRARY} | ||
| + GLEW::GLEW |
Contributor
There was a problem hiding this comment.
Typical patch which will breaks users 💣
Comment on lines
-54
to
-66
| "cuda": { | ||
| "description": "Build with CUDA.", | ||
| "dependencies": [ | ||
| "cuda", | ||
| "glew" | ||
| ] | ||
| }, | ||
| "cuda-redist": { | ||
| "description": "Redistributable CUDA support for common supported compute architectures.", | ||
| "dependencies": [ | ||
| "cuda" | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
Nobody wants to remove CUDA from COLMAP. (Or back to 🧮?)
Contributor
Author
|
Convert to draft. Wait for the fix and discussion upstream that mentioned |
Contributor
Author
|
Duplicate of #43695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port
freetype-glfailed withinclude/GL/glew.h:1219:14: fatal error: GL/glu.h: No such file or directorywhich found in when check #43363 (review)Change
GLEW_NO_GLUtoglewforglew_head.hby backporting Add INTERFACE definition GLEW_NO_GLU for glew_head.h nigels-com/glew#426freetype-gldependency:GLEW::GLEWcolmapfeaturecuda, report upstream Option GPU_ENABLED build failed: SiftGPU requires dependency GLUT colmap/colmap#3144Checklist
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Test
The port
glew,freetype-gl,colmapinstallation tests pass with the following triplets: