Merged
Conversation
dg0yt
reviewed
Oct 3, 2024
lrineau
added a commit
to lrineau/vcpkg
that referenced
this pull request
Oct 7, 2024
Thanks for the review. [review by @dg0yt]: microsoft#41300 (review)
Thanks for the review. [review by @dg0yt]: microsoft#41300 (review)
patch from upstream PR CGAL/cgal#8523
dg0yt
reviewed
Oct 8, 2024
Contributor
dg0yt
left a comment
There was a problem hiding this comment.
Given that the lib is header-only now:
- I wonder if the port still needs the
vcpkg_buildpath_length_warning. - I suggest to start the portfile with
set(VCPKG_BUILD_TYPE release) # header-only
Please update the PR title to correctly reference [cgal]. This will appear in git history.
ports/cgal/PR-8523__CGAL_CGAL-protect_against_macro_free-GF.patch
Outdated
Show resolved
Hide resolved
Thanks again. Ref: microsoft#41300 (review)
No need to bump the version, because the previous build of 6.0 failed.
No need to bump the version, because the previous build of 6.0 failed.
Contributor
Author
|
@WangWeiLin-MV This pull-request is no longer a draft, and now passes the CI tests. 😌 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to CGAL version 6.0. That new version has several breaking changes, but it seems nothing broke in vcpkg.
./vcpkg x-add-version --alland committing the result.