Skip to content

[msquic] update to 2.4.5, Change to openssl3 and remove uwp support.#41219

Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom
talregev:TalR/msquic_openssl3
Sep 30, 2024
Merged

[msquic] update to 2.4.5, Change to openssl3 and remove uwp support.#41219
JavierMatosD merged 1 commit intomicrosoft:masterfrom
talregev:TalR/msquic_openssl3

Conversation

@talregev
Copy link
Copy Markdown
Contributor

@talregev talregev commented Sep 27, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev talregev force-pushed the TalR/msquic_openssl3 branch from 9edbfd8 to 527a46a Compare September 27, 2024 17:35
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Sep 27, 2024 •
edited
Loading

the commit 612d8e44d687e4b71c4724319d7aa27a733bcbca
is OpenSSL 1_1_1w+quic and not openssl-3.1.5+quic as HEAD_REF suggested.

I am changing to quictls/openssl3 because I think it more important to update to newer ssl version.
I remove uwp support because it doing compilation error of multiple definition symbols.

@talregev talregev force-pushed the TalR/msquic_openssl3 branch 2 times, most recently from ded0ea8 to acaf09f Compare September 27, 2024 17:51
@talregev talregev changed the title [msquic] Change to openssl3 remove uwp support [msquic] Change to openssl3 and remove uwp support. Sep 27, 2024
@talregev talregev force-pushed the TalR/msquic_openssl3 branch 2 times, most recently from a7d8553 to 7474686 Compare September 27, 2024 17:58
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Sep 28, 2024 

failed (exit code 1169) with the following output:
LINK : warning LNK4075: ignoring '/MANIFESTUAC' due to '/MANIFEST:NO' specification
OneCore.lib(KERNEL32.dll) : error LNK2005: VirtualAlloc already defined in platform.lib(datapath_winuser.c.obj)
   Creating library obj\Debug\msquic.lib and object obj\Debug\msquic.exp
bin\Debug\msquic.dll : fatal error LNK1169: one or more multiply defined symbols found
ninja: build stopped: subcommand failed.

failure logs for x64-uwp.zip

@talregev talregev changed the title [msquic] Change to openssl3 and remove uwp support. [msquic] update to 2.4.5, Change to openssl3 and remove uwp support. Sep 28, 2024
@talregev talregev force-pushed the TalR/msquic_openssl3 branch from 7474686 to 19bb2c5 Compare September 28, 2024 12:59
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Sep 29, 2024
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 29, 2024
@JavierMatosD JavierMatosD merged commit bbe8dbd into microsoft:master Sep 30, 2024
@talregev talregev deleted the TalR/msquic_openssl3 branch September 30, 2024 21:37
@dg0yt dg0yt mentioned this pull request Dec 21, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cheney-W Cheney-W Cheney-W approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@talregev @Cheney-W @JavierMatosD