[rmqcpp] Update to latest revision#40101
Conversation
ab7e6c9 to
b70f132
Compare
|
About that version thing, I saw there are port versions and thought that would be the place to indicate the change. I wanted to go and edit that but I don't exactly know how this bit works (couldn't find docs about it or help in the CLI) so, scared of breaking things, I've rolled it back to an overwritten version. |
|
@SirWrexes Thanks for posting this PR. You can refer to versioning for more information about the version. :) |
|
@microsoft-github-policy-service agree |
|
So, if I get this right, I should run |
|
@SirWrexes
If it is not an updated port version, then: |
|
@SirWrexes A simple example PR. Hope it helps you. :) |
|
Despite setting the port to checkout a more recent commit, the package in question indeed doesn't change version. After reading some more documentation (including the one you've link) and understanding the tooling better, I found I could set I'm sending the changes now. |
|
That should do it. Thank you very much for your time and help ! |
dg0yt
left a comment
There was a problem hiding this comment.
This port has a lot of host dependencies which do not make any sense.
Now that you mention it, yes,
Regarding this part, I've checked their CMake files and... I don't think that's possible ? |
| }, | ||
| "boost-asio", | ||
| "boost-iostreams", | ||
| "gtest", |
There was a problem hiding this comment.
Despite only being needed for tests, gtest is set as a non-host dependency since there is no way to disable tests in the port for now.
There was a problem hiding this comment.
The test dirs are removed from the build. What is left?
There was a problem hiding this comment.
Did you try building the port without this dependency? the patch above that deletes add_subdirectory(tests) from CMakeLists.txt should make it so that this dependency is no longer needed.
Then the simplest disabler is a patch which removes the |
|
Noted, will do when I get some free time (currently in a dev rush)! 🫡 |
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
|
Hello there |
|
I got mixed in my commands and pushed the wrong commit when amending last commit. I'm embarrassing myself... 🤦 |
|
Done. By the way, sorry for being messy about it, and thank you very much for your patience and understanding. 🫶 |
dg0yt
left a comment
There was a problem hiding this comment.
Versioning seems to be complete strange now. Misleading review comments.
If version is not incremented, port-version must be incremented.
If version is incremented, port-version must be reset to 0.
But upstream can't have two different refs for the same release.
| }, | ||
| "boost-asio", | ||
| "boost-iostreams", | ||
| "gtest", |
There was a problem hiding this comment.
The test dirs are removed from the build. What is left?
So... Setting port version to 1 was actually right ?
That is what I read from the docs and is precisely why I up'd the port version. |
|
Would it be possible to clarify what is missing to merge this PR? |
|
@FrankXie05 Thank you! |

Fixes #38736
./vcpkg x-add-version --alland committing the result.**
--overwrite-versionwas used, as this is still1.0.0, minus a build failure.I thought having a version like
1.0.1or1.0.0-1could be a confusing divergence from the lib's versioning and didn't really make sense. Let me know if I should patch it with something different. 🫡