Conversation
Fixes microsoft#38494 Resurrects microsoft#38538 Co-authored-by: xb284524239 <40262910+xb284524239@users.noreply.github.com>
dg0yt
left a comment
There was a problem hiding this comment.
The build_arch thing may come from vcpkg_configure_meson. But meson uses a different terminology.
Cf. git grep 'ARM|arm'.
| else() | ||
| set(build_arch $ENV{PROCESSOR_ARCHITECTURE}) | ||
| endif() | ||
| if((build_arch MATCHES "^(ARM|arm)64$") OR (build_arch MATCHES "^(ARM|arm)$")) |
There was a problem hiding this comment.
Can we use arm64 binaries on ^(ARM|arm)$?
(This regex is used a few times with VCPKG_TARGET_ARCHITECTURE but never for the host.)
| if(DEFINED ENV{PROCESSOR_ARCHITEW6432}) | ||
| set(build_arch $ENV{PROCESSOR_ARCHITEW6432}) | ||
| else() | ||
| set(build_arch $ENV{PROCESSOR_ARCHITECTURE}) | ||
| endif() | ||
| if((build_arch MATCHES "^(ARM|arm)64$") OR (build_arch MATCHES "^(ARM|arm)$")) |
There was a problem hiding this comment.
| if(DEFINED ENV{PROCESSOR_ARCHITEW6432}) | |
| set(build_arch $ENV{PROCESSOR_ARCHITEW6432}) | |
| else() | |
| set(build_arch $ENV{PROCESSOR_ARCHITECTURE}) | |
| endif() | |
| if((build_arch MATCHES "^(ARM|arm)64$") OR (build_arch MATCHES "^(ARM|arm)$")) | |
| if(DEFINED ENV{PROCESSOR_ARCHITEW6432}) | |
| set(HOST_ARCH $ENV{PROCESSOR_ARCHITEW6432}) | |
| else() | |
| set(HOST_ARCH $ENV{PROCESSOR_ARCHITECTURE}) | |
| endif() | |
| if(HOST_ARCH MATCHES "^(ARM|arm)64$") |
"host" is the term used in vcpkg. HOST_ARCH is the variable used for the other platforms here. Non-64 arm is not a relevant host arch for windows
|
I was surprised to see new android errors. Now I checked the fine print. The errors are related to module support in CMake since 3.28. Module support is enabled under some conditions. For Ninja generators, it needs at least Ninja 1.11. This is what is changed by this PR. The immediate mitigation might be adding https://cmake.org/cmake/help/latest/manual/cmake-cxxmodules.7.html |
|
What's the status on this? Currently having issues with Ninja 1.10 hitting the 260 character path length limit on Windows when trying to build the gRPC port, and Ninja 1.12 would fix this. |
Hello, first you can manually download With this, you should be able to use ninja version 1.12.1 in vcpkg. |
Fixes #38494
Resurrects #38538