Skip to content

Fix error C2338 in botan#3877

Merged
alexkaratarakis merged 1 commit intomicrosoft:masterfrom
Cheney-W:FixBotan
Jul 12, 2018
Merged

Fix error C2338 in botan#3877
alexkaratarakis merged 1 commit intomicrosoft:masterfrom
Cheney-W:FixBotan

Conversation

@Cheney-W
Copy link
Copy Markdown
Contributor

@Cheney-W Cheney-W commented Jul 10, 2018 •
edited
Loading

  1. Botan failed with error C2338, it should fix form the error message provides the instructions that add -D_ENABLE_EXTENDED_ALIGNED_STORAGE option.
  2. Verified the latest botan 2.7.0 and error C2338 still exists, so add this patch in botan 2.6.0.

@Cheney-W
Copy link
Copy Markdown
Contributor Author

Cheney-W commented Jul 10, 2018

@alexkaratarakis, please help review and merge this PR.

@alexkaratarakis alexkaratarakis merged commit 6cd3632 into microsoft:master Jul 12, 2018
@alexkaratarakis
Copy link
Copy Markdown
Contributor

alexkaratarakis commented Jul 12, 2018

Thanks!

@alexkaratarakis alexkaratarakis mentioned this pull request Jul 12, 2018
Closed
@Cheney-W Cheney-W deleted the FixBotan branch June 13, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cheney-W @alexkaratarakis